-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logger interface for histograms #125
Fix logger interface for histograms #125
Conversation
Log vector was used to log.. vectors under the histogram interface, but those are technically not histograms. It was a functionality used by some people so I would not remove it. |
Ok I did not realize this. It seemed like keeping |
I brought back |
For now I am leaving it as is, we can decide on deprecation later. |
I noticed that the example for histograms at
examples/Histograms.jl
was not generating the histogram forhistogram/loggerinterface/autobin
.That is, the logging interface for histograms is broken (perhaps because of my previous PR #124 ).
This PR fixes this issue.
In fixing the issue, I made some changes to how histograms are made, in two ways:
fit(Histogram, data, [bins])
instead of callingHistogram(...)
which makes the code clearer, more concise and frees the user of the constraint of havingbins
of a specific length if he wishes to specify them.Since I am deleting functions here, we might want to bring them back and mark them as deprecated instead of deleting outright. Please let me know of such cases.
P.S. The hostogram examples themselves contained mistakes, so I fixed that as well.