Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorize progress bars #12

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Colorize progress bars #12

merged 1 commit into from
Jan 28, 2020

Conversation

tkf
Copy link
Collaborator

@tkf tkf commented Jan 26, 2020

I suggest using green for active progress bars and gray for completed progress bars. ATM, we don't use any color.

Example (with JuliaCI/BenchmarkTools.jl#153):

Peek 2020-01-25 22-43

@codecov-io
Copy link

codecov-io commented Jan 26, 2020

Codecov Report

Merging #12 into master will decrease coverage by 1.71%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   96.37%   94.66%   -1.72%     
==========================================
  Files           4        4              
  Lines         193      206      +13     
==========================================
+ Hits          186      195       +9     
- Misses          7       11       +4
Impacted Files Coverage Δ
src/TerminalLogger.jl 91.17% <100%> (-3.27%) ⬇️
src/ProgressMeter/ProgressMeter.jl 95.65% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6523ed7...26029d5. Read the comment docs.

@c42f
Copy link
Member

c42f commented Jan 28, 2020

Nice, looks great to me 👍

@tkf tkf merged commit 4af99eb into JuliaLogging:master Jan 28, 2020
@tkf tkf deleted the colorful-progress branch January 28, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants