Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a copy(M,p) and a copy(M, p, X) command #77

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

kellertuer
Copy link
Member

...to easily copy points and tangent vectors (recursively) into newly allocated memory.

@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #77 (ca1aee4) into master (516a43e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ca1aee4 differs from pull request most recent head c534f94. Consider uploading reports for the commit c534f94 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   99.84%   99.85%           
=======================================
  Files          14       14           
  Lines        1330     1338    +8     
=======================================
+ Hits         1328     1336    +8     
  Misses          2        2           
Impacted Files Coverage Δ
src/ManifoldsBase.jl 99.14% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516a43e...c534f94. Read the comment docs.

@kellertuer
Copy link
Member Author

Maybe the patch test was too early since the comment already contradicts this? However, tests cover the new code, we still only have two lines missing due to an macro-function codecov error, maybe the same as JuliaLang/julia#36283

Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 👍 .

@kellertuer kellertuer merged commit c53b7a9 into master Jun 28, 2021
@kellertuer kellertuer deleted the kellertuer/introduce-copy branch November 1, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants