Skip to content

Commit

Permalink
Custom inverse retraction for StopWhenChangeLess (#144)
Browse files Browse the repository at this point in the history
* Custom inverse retraction for `StopWhenChangeLess`
* bump version
  • Loading branch information
mateuszbaran authored Aug 5, 2022
1 parent fbdb608 commit 76eeac7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Manopt"
uuid = "0fc0a36d-df90-57f3-8f93-d78a9fc72bb5"
authors = ["Ronny Bergmann <[email protected]>"]
version = "0.3.36"
version = "0.3.37"

[deps]
ColorSchemes = "35d6a980-a343-548e-a6ea-1d62b119f2f4"
Expand Down
2 changes: 1 addition & 1 deletion src/plans/stopping_criterion.jl
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ end
function (c::StopWhenChangeLess)(P::Problem, O::Options, i)
if has_storage(c.storage, :x)
x_old = get_storage(c.storage, :x)
d = distance(P.M, O.x, x_old)
d = distance(P.M, O.x, x_old, default_inverse_retraction_method(P.M))
if d < c.threshold && i > 0
c.reason = "The algorithm performed a step with a change ($d) less than $(c.threshold).\n"
c.storage(P, O, i)
Expand Down

2 comments on commit 76eeac7

@kellertuer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/65697

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.3.37 -m "<description of version>" 76eeac7108a44cbce793281bd8ab83bde83cf536
git push origin v0.3.37

Please sign in to comment.