-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add region(::Plan)
for accessing transformed region
#65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 82.92% 83.09% +0.16%
==========================================
Files 2 2
Lines 205 207 +2
==========================================
+ Hits 170 172 +2
Misses 35 35
Continue to review full report at Codecov.
|
Sounds good -- since I use |
Thanks! I renamed (We may want to go back and change the name |
Currently, there is no official and consistent way for accessing the transformed region of a FFT plan. For many plans,
plan.region
works but e.g. it fails forScaledPlan
. This is problematic when one tries to write generic implementations, e.g., of derivatives (see, e.g., JuliaMath/FFTW.jl#182).This PR adds a function
region(p::Plan)
that can be used to access the region of a plan. It falls back top.region
but can be specialized, e.g., forScaledPlan
.