Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the API definitions to a new package, CheckedArithmeticCore #8

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

kimikage
Copy link
Collaborator

Closes #6

This also add support for div and % in @checked. (Fixes #4)
This switches the CI from Travis to GitHub Actions, and adds Julia v1 and 32-bit x86 to the test target.

This also add support for `div` and `%` in `@checked`.
This switches the CI from Travis to GitHub Actions,
and adds Julia v1 and 32-bit x86 to the test target.
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@50243f0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   63.35%           
=========================================
  Files             ?        1           
  Lines             ?      131           
  Branches          ?        0           
=========================================
  Hits              ?       83           
  Misses            ?       48           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50243f0...7de035d. Read the comment docs.

@timholy timholy merged commit d7f9183 into JuliaMath:master Sep 17, 2020
@timholy
Copy link
Member

timholy commented Sep 17, 2020

Thanks!

@kimikage
Copy link
Collaborator Author

There is still work to be done within CheckedArithmeticCore, but I think we need to register only CheckedArithmeticCore first, as it is a new package and registration will take 3 days.

I don't have any experience with registering a package in a subdirectory, is the following method available?
https://github.com/JuliaRegistries/Registrator.jl#registering-a-package-in-a-subdirectory

@kimikage kimikage deleted the core branch September 17, 2020 12:35
@timholy
Copy link
Member

timholy commented Sep 17, 2020

I've only done it once, for SnoopCompile, and that was before that was available. So no clue, but seems worth trying.

@kimikage
Copy link
Collaborator Author

It seems to be working well. It's great.
JuliaRegistries/General#21528

@kimikage kimikage mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separation to CheckedArithmeticCore Supporting div and %
2 participants