-
Notifications
You must be signed in to change notification settings - Fork 34
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ os: | |
- osx | ||
julia: | ||
- 1.0 | ||
- 1.2 | ||
- 1 | ||
- nightly | ||
notifications: | ||
email: false | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6e2c1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuliaRegistrator register()
a6e2c1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Registration pull request created: JuliaRegistries/General/8809
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
a6e2c1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this release breaking?
a6e2c1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by that?
FixedPointNumbers v0.8 is currently not used in many packages in the JuliaGraphics/JuliaImages, due to major changes in ColorTypes.jl and Colors.jl and their delays of tag releasing. (We are almost ready for release.)
Since v0.7, FixedPointNumbers has many changes, including breaking changes. Due to the reason above, the compatibilities have not been sufficiently verified.
a6e2c1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the change log, most of the differences are in return types, allowed bounds, and returned numeric values. If you're not sensitive to these issues, it's probably not terribly breaking.
a6e2c1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the logs and wasn't really sure if it was willingly breaking, or just minor changes that shouldn't break anything but may... ;)
Thanks for the clarification :)
a6e2c1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might expect ulp-level breakages to a few tests. And possibly need to convert some
@test_broken
s into@test
, but that's the kind of breakage we can all live with!@kimikage has done wonders for the internal machinations of this package, it's a faster and far more accurate & elegant package than it was a few months ago.
a6e2c1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :) I'm not complaining at all, just couldn't figure out immediately from the logs, how careful I need to be with upping the compat bounds!
a6e2c1d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, I (or we) plan to improve the arithmetic in the next v0.9, but we may have to release the patches for v0.8, so I'm suspending the improvement now.