Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitstring for FixedPoint numbers #195

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Jul 8, 2020

WRT the issue #185, this is the last PR which is ready to be included in the v0.8.x.

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #195 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   88.98%   89.01%   +0.02%     
==========================================
  Files           6        6              
  Lines         445      446       +1     
==========================================
+ Hits          396      397       +1     
  Misses         49       49              
Impacted Files Coverage Δ
src/FixedPointNumbers.jl 85.85% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c90fb6...f075e6d. Read the comment docs.

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For things this straightforward, feel free to just merge.

@kimikage kimikage merged commit c1c4e69 into JuliaMath:master Jul 12, 2020
@kimikage kimikage deleted the bitstring branch July 12, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants