Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GSL v2.6 #103

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Upgrade to GSL v2.6 #103

merged 3 commits into from
Oct 29, 2019

Conversation

giordano
Copy link
Member

Just using the new binaries makes tests pass locally, let's see how it goes with the rest of CI.

I guess we may want to upgrade the wrappers too (see #102), so I'm marking this pull request as draft.

Fix #102.

@giordano giordano requested a review from ludvigak October 26, 2019 15:42
@codecov-io
Copy link

codecov-io commented Oct 26, 2019

Codecov Report

Merging #103 into master will decrease coverage by 0.04%.
The diff coverage is 1.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #103      +/-   ##
=========================================
- Coverage    7.04%   6.99%   -0.05%     
=========================================
  Files         189     189              
  Lines        5282    5348      +66     
=========================================
+ Hits          372     374       +2     
- Misses       4910    4974      +64
Impacted Files Coverage Δ
src/gen/direct_wrappers/gsl_integration_h.jl 6.81% <ø> (ø) ⬆️
...gen/direct_wrappers/gsl_permute_vector_double_h.jl 0% <ø> (ø) ⬆️
src/gen/direct_wrappers/gsl_filter_h.jl 0% <ø> (ø) ⬆️
src/gen/direct_wrappers/gsl_randist_h.jl 0% <ø> (ø) ⬆️
src/gen/gsl_types.jl 100% <ø> (ø) ⬆️
src/gen/direct_wrappers/gsl_vector_double_h.jl 10.86% <0%> (-0.25%) ⬇️
src/gen/direct_wrappers/gsl_vector_ushort_h.jl 0% <0%> (ø) ⬆️
src/gen/direct_wrappers/gsl_vector_ulong_h.jl 0% <0%> (ø) ⬆️
src/gen/direct_wrappers/gsl_vector_short_h.jl 0% <0%> (ø) ⬆️
src/gen/direct_wrappers/gsl_matrix_char_h.jl 0% <0%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436eecc...ef22038. Read the comment docs.

Copy link
Collaborator

@ludvigak ludvigak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I re-generated the wrappers from the 2.6 source, let's see if it passes...

I had to ignore the new gsl_bst* stuff, because it uses C unions, which I don't know an easy way of dealing with.

@ludvigak ludvigak marked this pull request as ready for review October 29, 2019 12:55
@ludvigak ludvigak merged commit ee0ec85 into JuliaMath:master Oct 29, 2019
@giordano giordano deleted the upgrade-v2.6 branch October 29, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to GSL 2.6
3 participants