Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project.toml to use openspecfun 0.5.5 and julia 1.6 #324

Closed
wants to merge 6 commits into from

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Jun 2, 2021

This PR bumps the Julia minimum version to 1.6, in order to use openspecfun v0.5.5 (which pulls in a fix for JuliaPackaging/BinaryBuilderBase.jl#92).

I am considering bumping the SpecialFunctions.jl version to 1.5, so that Julia 1.6 and higher can continue to lower bound and always pick up the fixed openspecfun. There are no reported problems that necessitate the fix, so older releases should continue to be fine. We just pick this up going forward.

@ViralBShah ViralBShah force-pushed the vs/openspefun-0.5.5 branch from 056204b to 4feaa32 Compare June 2, 2021 12:15
@giordano
Copy link
Member

giordano commented Jun 2, 2021

Following up from #323

I do need to drop older versions, so that I can force using openspecfun v0.5.5

But we don't need to force it, the package manager will naturally pick it up. OpenSpecFun_jll is only used directly by this package, so there isn't even the risk of having incompatibilities between different packages. I don't think we need to drop versions before 1.6 at this time

@ViralBShah
Copy link
Member Author

ViralBShah commented Jun 2, 2021

That's what I thought too, but something was pinning openspecfun to 0.5.3 on Julia 1.3. Any thoughts how to do this better?

https://github.com/JuliaMath/SpecialFunctions.jl/runs/2727511037

@giordano
Copy link
Member

giordano commented Jun 2, 2021

Something was pinning openspecfun to 0.5.3 on Julia 1.3. Any thoughts how to do this better?

New versions (since v0.5.4) of OpenSpecFun_jll do require Julia v1.6, to make it possible to build for aarch64-apple-darwin: JuliaPackaging/Yggdrasil#2892. So no, for older versions of Julia there is no way to convince it to pick up v0.5.5

@ViralBShah
Copy link
Member Author

ViralBShah commented Jun 2, 2021

Does GHA have arm builds? If so, we can reduce the dependency on drone. I suppose travis is good to have for freebsd.

@ViralBShah ViralBShah changed the title Update Project.toml to use julia compat version as 1.6 Update Project.toml to use openspecfun 0.5.5 and julia 1.6 Jun 2, 2021
@ViralBShah
Copy link
Member Author

ViralBShah commented Jun 2, 2021

So now the failure is only on armv7. Seems like travis is going away in a couple of weeks - is it straightforward to migrate it to .com?

@ViralBShah
Copy link
Member Author

It turns out that we don't need any of this. Closing.

@ViralBShah ViralBShah closed this Jun 2, 2021
@ViralBShah ViralBShah deleted the vs/openspefun-0.5.5 branch June 2, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants