Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Project files #41

Merged
merged 3 commits into from
May 29, 2020
Merged

Fix Project files #41

merged 3 commits into from
May 29, 2020

Conversation

Tokazama
Copy link
Member

I completely forgot to check dependencies on the last PR. This also sets the test dependencies more appropriately.

@Tokazama
Copy link
Member Author

Looks like I'm hitting problems with Julia 1.0 not supporting the new test files format. It might be fine to just test 1.4+ from now on given Julia should have a new LTS soon.

@Tokazama
Copy link
Member Author

I'll leave this open for one more day in case anyone wants to comment. It basically will mean that NIfTI.jl doesn't officially test/support anything pre-1.4.

@korbinian90
Copy link
Contributor

I think it's good to drop the dependency to Test, but I'm not sure if it's worth to lose v1.0 testing.

As I understand it, the package would be still compatible with v1.0, just not tested and thus not officially supported. So it would be easy that v1.0 incompatibilities sneak in to the "stable Julia v1.0 LTS" environment. Forcing the compatibilty to a higher Julia version on the other hand would then require for all packages building on NIfTI.jl to drop v1.0 support.

I think the Julia pre-1.2 approach would be a good option: with [extras] and [targets] in the Project.toml
If you have both test configurations, all >1.2 versions use the newer test/Project.toml file and pre-1.2 uses the old approach. The only disadvantage would be to keep test dependencies updated in both places.

I copied your pull request (without the last commit) and tried it there (Travis test is passing for Julia v1.0):

korbinian90@666bc40

@Tokazama
Copy link
Member Author

I think that Julia 1.6 will be the next LTS and TBH a lot of stuff that I plan to incorporate soon will be pretty difficult to ensure compatibility with anything before 1.3. In other words, ensuring compatibility with v1.0 is unlikely to make a difference once new features are added.

That being said, I'd be open to supporting the pre v1.2 test stuff in the Project.toml if it really is helping anyone for the time being.

@Tokazama Tokazama merged commit 6b0ffc0 into JuliaNeuroscience:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants