Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some basic house keeping #49

Merged
merged 6 commits into from
Feb 12, 2021
Merged

Conversation

Tokazama
Copy link
Member

Changes:

  • NIVolume and NIfTI1Extension don't need to be mutable
  • use parsing functions instead of slower dictionary look up for converting header info
  • use updated workflows for coverage tests

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@e72842f). Click here to learn what that means.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #49   +/-   ##
=========================================
  Coverage          ?   43.69%           
=========================================
  Files             ?        2           
  Lines             ?      357           
  Branches          ?        0           
=========================================
  Hits              ?      156           
  Misses            ?      201           
  Partials          ?        0           
Impacted Files Coverage Δ
src/parsers.jl 8.16% <8.16%> (ø)
src/NIfTI.jl 68.57% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72842f...095759a. Read the comment docs.

@Tokazama Tokazama merged commit 8c27ae2 into JuliaNeuroscience:master Feb 12, 2021
@Tokazama Tokazama deleted the house_keeping branch February 12, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant