added support for INT16 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tokazama could you please take a look at my changes and consider a merge. We need your NIfTI package for one of our projects, and we require to save masks with INT16 values. Thanks |
|
Sorry I haven't been on github the past week. Would you mind making a simple test for this so we don't break Int16 support in the future? |
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 52.27% 51.54% -0.74%
==========================================
Files 6 6
Lines 549 551 +2
==========================================
- Hits 287 284 -3
- Misses 262 267 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
sure. I added a test for INT16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there is another pull request for solving the same problem, but I looked at the code, and my solution seems more in tune with the current structure.