Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Aqua #106

Merged
merged 3 commits into from
May 15, 2023
Merged

add Aqua #106

merged 3 commits into from
May 15, 2023

Conversation

jw3126
Copy link
Member

@jw3126 jw3126 commented May 14, 2023

fix #105

@jw3126
Copy link
Member Author

jw3126 commented May 15, 2023

Anybody knows what the CI Invalidations failure is about? Does not look related to my code?

@aplavin
Copy link
Member

aplavin commented May 15, 2023

Nice catch, those ambiguities!
Regarding show - turns out your "little concern" from #66 (review) actually materialized, in Base itself :)

On invalidations failure - idk, maybe some part of that action is simply experimental/unstable for now?

@aplavin
Copy link
Member

aplavin commented May 15, 2023

Not sure if it helps someone debug the issue, but the error line

  [90137ffa] ERROR: MethodError: no method matching stat_rep(::Nothing)

refers to the UUID of StaticArrays,
https://github.com/JuliaRegistries/General/blob/master/S/StaticArrays/Package.toml#L2

@jw3126
Copy link
Member Author

jw3126 commented May 15, 2023

@aplavin what do you think shall we merge this?

@aplavin
Copy link
Member

aplavin commented May 15, 2023

I'm all for adding Aqua tests!
Invalidations action failure definitely unrelated, it throws the same for all other recent PRs.

@jw3126 jw3126 merged commit 0019c22 into master May 15, 2023
@jw3126 jw3126 deleted the aqua branch May 15, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base.show ambiguity
2 participants