Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show optics as @o #139

Merged
merged 3 commits into from
Feb 28, 2024
Merged

show optics as @o #139

merged 3 commits into from
Feb 28, 2024

Conversation

aplavin
Copy link
Member

@aplavin aplavin commented Feb 26, 2024

No description provided.

@aplavin aplavin marked this pull request as ready for review February 26, 2024 18:00
@jw3126
Copy link
Member

jw3126 commented Feb 27, 2024

This is a good idea 👍

@jw3126
Copy link
Member

jw3126 commented Feb 27, 2024

We should also mention @o in the docstring.

@aplavin aplavin requested a review from jw3126 February 28, 2024 02:38
Copy link
Member

@jw3126 jw3126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aplavin aplavin merged commit 48fa640 into JuliaObjects:master Feb 28, 2024
6 of 8 checks passed
@aplavin aplavin deleted the show branch February 28, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants