Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message #166

Merged
merged 1 commit into from
Aug 26, 2024
Merged

improve error message #166

merged 1 commit into from
Aug 26, 2024

Conversation

aplavin
Copy link
Member

@aplavin aplavin commented Aug 25, 2024

Was a bit confusing, eg:

julia> set(1, year, 123)
ERROR: This should be unreachable. You probably need to overload
`Accessors.set(obj, ::typeof(year), val)

even though set() with year already exists, but defined for dates only.
With this PR:

julia> set(1, year, 123)
ERROR: This should be unreachable. You probably need to overload
`Accessors.set(obj::Int64, ::typeof(year), val::Int64)`

Copy link
Member

@jw3126 jw3126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aplavin aplavin merged commit d737c58 into JuliaObjects:master Aug 26, 2024
6 of 8 checks passed
@aplavin aplavin deleted the err branch August 27, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants