Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use modify in delete/insert #49

Merged
merged 1 commit into from
Apr 30, 2022
Merged

use modify in delete/insert #49

merged 1 commit into from
Apr 30, 2022

Conversation

aplavin
Copy link
Member

@aplavin aplavin commented Apr 29, 2022

No description provided.

Copy link
Member

@jw3126 jw3126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM! Shall I merge?

@aplavin
Copy link
Member Author

aplavin commented Apr 30, 2022

Yes!
I should've used modify here from the beginning.

@jw3126 jw3126 merged commit 25ffca9 into JuliaObjects:master Apr 30, 2022
@aplavin aplavin deleted the patch-1 branch April 30, 2022 06:20
@jw3126
Copy link
Member

jw3126 commented Apr 30, 2022

No worries, I also missed it. But thanks a lot for coming back and fixing!

aplavin pushed a commit to aplavin/Accessors.jl that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants