[Runner] Work around wrong path of compiler libraries for riscv64. Again #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/riscv64-lib64
branch
from
79b44b0 to
414d3a2
Compare
|
Ok, I believe this should be working now, tests were failing before because I was testing |
giordano
force-pushed
the
mg/riscv64-lib64
branch
from
414d3a2 to
6693bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how this has happened, because I thought this was resolved by JuliaPackaging/Yggdrasil@
123ac9b(#10132) (and the path is right for x86_64, aarch64, and powerpc64le), but the compiler support libraries ended up again inlib/instead oflib64/for riscv64, so we have to repeat #402. I thought we had a test about this (create a C++ library, and link to it withcc), apparently we don't, probably we should, but I don't have the time to add it right now.