[Libffi] Temporary revert to 3.2.2 to build for aarch64-freebsd #10016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the following commits: - "[Libffi] Rebuild for freebsd-aarch64 (JuliaPackaging#9909)": 670483c - "Libffi: Build for aarch64-freebsd (JuliaPackaging#9782)": f66e34e - "Libffi: New version 3.4.6 (JuliaPackaging#8275)": ff6c554 - "[Libffi] Upgrade to v3.4.4 (JuliaPackaging#5834)": cca8463
JamesWrigley
force-pushed
the
libffi-compat
branch
from
d4737ab to
c26ae0e
Compare
JamesWrigley
force-pushed
the
libffi-compat
branch
from
c26ae0e to
fdb28ac
Compare
|
I'm guessing the compilers have been updated since last time this was built, on aarch64-apple-darwin the build was hitting this error: llvm/llvm-project#72802 TL;DR: newer LLVM versions are pickier about the operations allowed in |
JamesWrigley
added a commit
to JamesWrigley/Yggdrasil
that referenced
this pull request
Dec 17, 2024
…sd (JuliaPackaging#10016)" This reverts commit c82c599.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: #10006 (comment)
This reverts the following commits:
"libffi: Stop messing with the install diretory (libffi: Stop messing with the install directory #3906)": 7629d04Libffi has a more interesting commit history than Expat so I opted to revert all the commits newer than the change to 3.2.2 to be on the safe side. Interestingly, turns out that the JLL version 3.2.2 is actually building the library version 3.2.1.
EDIT: oops, #3906 wasn't a version change so that shouldn't have been reverted.