-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLVM] Rebuild for riscv64 #10204
[LLVM] Rebuild for riscv64 #10204
Conversation
For stdlibs we don't have to change version number |
We went very far with the compilation for riscv64, it failed only at linking libllvm:
Maybe another thing which requires GCC 14? I was able to compile LLVM on riscv64 with GCC 14.2 (it just took half a day 🥲) |
|
I haven't looked closely here yet uxlfoundation/oneTBB#186, but it sounds like there might be some arch-specific code paths in the ITT library there that might need fixing up. |
Looks like it comes from ittapi which llvm uses, https://github.com/llvm/llvm-project/blob/f4230b4332262dffb0bd3b7a2f8d6deb2e96488e/llvm/lib/ExecutionEngine/IntelJITProfiling/ittnotify_config.h#L263. |
But...why are we compiling this code path for riscv? 😕 For the record, my # -*- makefile -*-
override USECCACHE = 1
MARCH := rv64gcv
CFLAGS := -mabi=lp64d
CXXFLAGS := $(CFLAGS)
FFLAGS := $(CFLAGS)
USE_INTEL_JITEVENTS = 0
USE_BINARYBUILDER:=0
DEPS_GIT = llvm
override LLVM_VER=19.1.1
override LLVM_BRANCH=julia-release/19.x
override LLVM_SHA1=julia-release/19.x and Lines 251 to 253 in e3d93c0
|
Based on https://www.intel.com/content/www/us/en/developer/articles/system-requirements/vtune-profiler-system-requirements.html VTune is compatible only with x86_64, not even 32-bit systems (unless I'm missing something). Edit: I opened JuliaLang/julia#56964 to disable |
Currently we are enabling it for all Linux systems, but [Intel VTune supports only x86_64](https://www.intel.com/content/www/us/en/developer/articles/system-requirements/vtune-profiler-system-requirements.html) and building LLVM with ITTAPI support is problematic on some platforms (e.g. riscv64, ref: JuliaPackaging/Yggdrasil#10204).
Progress:
I guess the issue is that |
Couple of observations:
|
Mumble mumble mumble, I bet the problem is https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/4d0883a222bcb60871f8e24e56ef6e322502ec80/src/Runner.jl#L553-L559 + #10132 (comment): our compiler wrappers expect compiler libraries in the |
It's working! |
Thanks for debugging and getting this working. |
Congratulations! |
No description provided.