Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuiteSparse] Fix build for 64-bit BLAS #10215

Merged
merged 2 commits into from
Jan 7, 2025
Merged

[SuiteSparse] Fix build for 64-bit BLAS #10215

merged 2 commits into from
Jan 7, 2025

Conversation

imciner2
Copy link
Member

@imciner2 imciner2 commented Jan 7, 2025

The new builds were not properly mangling the symbol names to call 64-bit BLAS functions, as noticed in JuliaLang/julia#56959), this fixes that.

Also, remove hard-coded CMake version to let it get the newest version.

* Properly pass build option into the script section
* Remove hard-coded CMake version to let it get the newest
@giordano
Copy link
Member

giordano commented Jan 7, 2025

Need to touch the build_tarballs.jl file too

@imciner2 imciner2 merged commit ce22cc0 into master Jan 7, 2025
16 checks passed
@imciner2 imciner2 deleted the im/ssfix branch January 7, 2025 16:20
@ViralBShah
Copy link
Member

I see what I did wrong. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants