Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mbedtls to v2.24.0 #1674

Merged
merged 4 commits into from
Nov 3, 2020
Merged

Bump mbedtls to v2.24.0 #1674

merged 4 commits into from
Nov 3, 2020

Conversation

musm
Copy link
Contributor

@musm musm commented Sep 16, 2020

giordano
giordano reviewed Sep 16, 2020
View reviewed changes
M/MbedTLS/build_tarballs.jl Outdated
cmake -DCMAKE_INSTALL_PREFIX=$prefix -DCMAKE_TOOLCHAIN_FILE="${CMAKE_TARGET_TOOLCHAIN}" -DUSE_SHARED_MBEDTLS_LIBRARY=On
FLAGS=()
if [[ "${proc_family}" != intel ]]; then
FLAGS=(-DCMAKE_C_FLAGS="-Wno-type-limits")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, maybe it's better to look at Mbed-TLS/mbedtls#3449 rather than ignoring a warning 🤔

@giordano
Copy link
Member

Maybe use a version which builds cleanly without warnings?

@musm
Copy link
Contributor Author

musm commented Sep 16, 2020

many thanks 👏

Does it functionally matter if have to ignore the warnings? Otherwise, we can just wait until that fixup lands on a release version?

@giordano
Copy link
Member

Does it functionally matter if have to ignore the warnings?

Ignoring a warning means that we're ignoring a potential error, if that really matters in practice... 🤷

Otherwise, we can just wait until that fixup lands on a release version?

That's a good choice

@giordano giordano added the julia 💜 ❤️ 💚 Builders and issues related to Julia and its dependencies label Sep 23, 2020
@musm
Copy link
Contributor Author

musm commented Oct 21, 2020

Looks like the fix should be in soon Mbed-TLS/mbedtls#3799 (review)

@giordano
Copy link
Member

For the record, also here we're going to have compatibility problems: currently we have libmbedtls.so.12, this builds libmbedtls.so.13

@staticfloat
Copy link
Member

The safest way to do this is to ensure that all dependencies can be bumped to new versions as well, so that we can encode proper version requirements on those dependencies.

The dependency list of MbedTLS right now is:

  • LibSSH2 (Currently on version 1.9.0, which seems to be the latest) ✖️
  • LibCURL (Currently on version 7.71.1, can be bumped to 7.73.0) ✔️
  • LibGit2 (Currently on version 1.0.1, can be bumped to 1.1.0) ✔️
  • GDAL (Currently on version 3.0.4, can be bumped to 3.1.3) ✔️

@giordano
Copy link
Member

GDAL v3.1.3: #1928

@giordano
Copy link
Member

But bumping the requirement will mean that this will work only with Julia v1.6, when Julia will get the new MbedTLS?

@staticfloat
Copy link
Member

Right, so GDAL 3.1.3 would require MbedTLS 2.24.0+, which would then only work on Julia 1.6+

@giordano giordano mentioned this pull request Oct 22, 2020
Closed
@musm
Copy link
Contributor Author

musm commented Oct 22, 2020

For libssh see https://www.libssh2.org/mail/libssh2-devel-archive-2020-10/0001.shtml
I guess we could also just use master branch of libssh2 ?

@staticfloat staticfloat merged commit 546d980 into master Nov 3, 2020
@staticfloat staticfloat deleted the bump-mbedtls branch November 3, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
julia 💜 ❤️ 💚 Builders and issues related to Julia and its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@musm @giordano @staticfloat