XyceWrapper: support more julia versions #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
pushed a commit
to simeonschaub/Yggdrasil
that referenced
this pull request
Feb 23, 2022
* XyceWrapper: support more julia versions * XyceWrapper: set julia compat * XyceWrapper: 1.6 -> 1.6.3 * XyceWrapper: patch imported from jlqml * XyceWrapper: filter platforms
giordano
reviewed
Feb 24, 2022
| ] | ||
|
|
||
| # Build the tarballs, and possibly a `build.jl` as well. | ||
| build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; preferred_gcc_version=v"7") | ||
| build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; julia_compat = "1.6", preferred_gcc_version=v"7") |
There was a problem hiding this comment.
I just realised this required Julia v1.6 without changing the version number, which is a violation of second point of #2763. And this is why JuliaRegistries/General#54942 is stalling.
There was a problem hiding this comment.
Oh that is easy enough fix :). Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not 100% of the mechanics here. Let's give this a shot :)