[SDPA] rebuild with no changes for latest libcxxwrap #6760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 18, 2023
|
With this latest version, I'm seeing failures on Windows and Julia v1.9 
https://github.com/jump-dev/SDPA.jl/actions/runs/5017955895/jobs/8997264217?pr=57 Things are working on 1.6 and 1.10, so perhaps the uploaded binary just got corrupted? Any ideas? Do we just try rebuilding? |
|
We've seen this error randomly popping out, but no one understands it |
|
😢 so it sufficient to just rebuild? |
|
Unlikely |
|
Has this improved in Julia v1.10 ? We could try a rebuild and see. EDIT see #8129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref jump-dev/SDPA.jl#56
x-ref jump-dev/SDPA.jl#57
OpenSpiel is similar:
x-ref #6759
If we're going to rebuild libcxxwrap, #6726, does it make sense to also rebuild all dependent jll at the same time (or after, once version registered)? I can see this being a re-occuring pain point.