Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CompilerSupportLibraries] Upgrade to GCC 13 and move Win *.a files to subdir #7535

Merged
merged 1 commit into from
Oct 15, 2023
Merged

[CompilerSupportLibraries] Upgrade to GCC 13 and move Win *.a files to subdir #7535

merged 1 commit into from
Oct 15, 2023

Conversation

giordano
Copy link
Member

CC: @vtjnash

@giordano giordano force-pushed the mg/csl branch 2 times, most recently from 9275999 to 75c5ce3 Compare October 15, 2023 13:47
vtjnash
vtjnash reviewed Oct 15, 2023
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A folder name of julia seems odd for being gcc. I think lib/gcc/<triple>/<major> would be better (where they normally are located when using a vanilla build of gcc).

@giordano giordano force-pushed the mg/csl branch 2 times, most recently from 0c840b0 to aea51f8 Compare October 15, 2023 13:59
@giordano
Copy link
Member Author

Ok, I moved it to lib/gcc/<triple>. I excluded <major> just because we'd have to update the number in julia's Makefile every time we update CSL there, unless that's seen as a feature?

@vtjnash
Copy link
Member

vtjnash commented Oct 15, 2023

That is where other tools, such as gcc itself, will expect to find it

@giordano giordano force-pushed the mg/csl branch 2 times, most recently from fa7bee3 to 3d5f4f1 Compare October 15, 2023 22:53
@giordano
Copy link
Member Author

Alright, moved to the suggested directory, including the major version number.

@giordano giordano merged commit e3526b7 into JuliaPackaging:master Oct 15, 2023
@giordano giordano deleted the mg/csl branch October 15, 2023 22:59
@giordano giordano mentioned this pull request Oct 15, 2023
Merged
amontoison pushed a commit to amontoison/Yggdrasil that referenced this pull request Nov 27, 2023
@giordano @amontoison
[CompilerSupportLibraries] Upgrade to GCC 13 and move Win *.a files…
9d69a55 
… to subdir (JuliaPackaging#7535)
This was referenced Jan 4, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giordano @vtjnash