[Glib] Upgrade builder to v2.68.1 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I managed to build for all platforms excluding macOS and FreeBSD. On macOS, the problem is the native Objective-C compiler, meson stubbornly wants to check that it works and that it can run the generated executable. Actually, the program that it wants to compile is quite simple: #import<stdio.h>
int main() { return 0; }I tried fooling meson by defining I don't remember what was the problem with FreeBSD, I quickly gave up. |
giordano
commented
Sep 21, 2019
|
Now macOS build is failing before getting to the sanity check for the native Objective-C compiler: Which doesn't sound great. Relevant part of the log file: What's interesting is that if I compile the file shown in the log with the command shown in the log, I get no error and the command returns 0 🤔 😕 |
|
Ok, I found the culprit, and this isn't nice. See also https://gitlab.gnome.org/GNOME/glib/issues/1868 The relevant lines are https://gitlab.gnome.org/GNOME/glib/blob/2.62.0/glib/gnulib/gl_cv_func_frexpl_works/meson.build#L121-L126 if not meson.is_cross_build() or meson.has_exe_wrapper()
# ...
else
if (host_system.startswith ('aix') or
host_system.startswith ('beos') or
host_system.startswith ('darwin') or
host_system.startswith ('irix'))
gl_cv_func_frexpl_works = false
gl_cv_func_frexpl_broken_beyond_repair = true
elif (host_system == 'windows')
gl_cv_func_frexpl_works = false
gl_cv_func_frexpl_broken_beyond_repair = false
else
gl_cv_func_frexpl_works = true
gl_cv_func_frexpl_broken_beyond_repair = false
endif
endifSo, when the host system in a cross-compilation is Darwin (and a few others) it assumes (without actually compiling the code shown in the previous message) that frexpl is broken beyond repair, thus making it impossible to continue with the compilation. |
|
Glib 2.62 apparently is broken also for FreeBSD: I don't think this version has been ported at all to FreeBSD yet |
Merged
giordano
force-pushed
the
glib-2.62
branch
2 times, most recently
from
7b9a292 to
9dd56ce
Compare
|
Quick note to self: for FreeBSD look at http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/devel/glib2/patches/patch-meson.build?rev=1.2&content-type=text/x-cvsweb-markup, maybe there is something similar also in FreeBSD ports |
|
The macOS build is failing with because this is the command line invocation (original and verbose): The most relevant ingredients are My understanding is that when you do Edit: ok, I suspect the culprit is https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/1eab154d2ad8de0045cc69a181de1bd411cb0d35/src/Runner.jl#L411: our |
giordano
force-pushed
the
glib-2.62
branch
3 times, most recently
from
5e782ee to
f0ef8cd
Compare
giordano
changed the title
|
I can't believe this is finally working 😢 |
59 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a newer version of objcopy (binutils) in the builder environment to work