Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ambiguities on 1.8 & nightly #116

Merged
merged 2 commits into from
Mar 3, 2022
Merged

fix ambiguities on 1.8 & nightly #116

merged 2 commits into from
Mar 3, 2022

Conversation

Roger-luo
Copy link
Contributor

OK this should fix the nightly ambiguity - can we have a new patch release after this gets merged?

@Roger-luo Roger-luo requested a review from giordano March 2, 2022 20:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #116 (d0b9bd3) into master (d2edc82) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

❗ Current head d0b9bd3 differs from pull request most recent head 679fb6b. Consider uploading reports for the commit 679fb6b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   95.73%   95.54%   -0.20%     
==========================================
  Files          12       13       +1     
  Lines         727      740      +13     
==========================================
+ Hits          696      707      +11     
- Misses         31       33       +2     
Impacted Files Coverage Δ
src/Measurements.jl 87.87% <ø> (ø)
src/compat.1.8.jl 0.00% <0.00%> (ø)
src/utils.jl 100.00% <0.00%> (ø)
src/derivatives-type.jl 100.00% <0.00%> (ø)
src/math.jl 98.95% <0.00%> (+0.01%) ⬆️
src/conversions.jl 100.00% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2edc82...679fb6b. Read the comment docs.

src/compat.1.8.jl Outdated Show resolved Hide resolved
@giordano giordano merged commit b26fbff into master Mar 3, 2022
@giordano giordano deleted the roger/1.8-ambiguities branch March 3, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants