Fix Measurement{Float64}(::Rational) #20
Conversation
Before this, `Measurement{Float64}(2//1)` would result in
```julia
MethodError: Measurement{Float64}(::Rational{Int64}) is ambiguous. Candidates:
(::Type{Measurement{T}})(x::S) where {T, S} in Measurements at /home/twan/.julia/packages/Measurements/57KtG/src/Measurements.jl:61
(::Type{T})(x::Rational{S}) where {S, T<:AbstractFloat} in Base at rational.jl:90
Possible fix, define
(::Type{Measurement{T}})(::Rational{S})
```
on Julia 1.0.
|
CI failures unrelated. |
|
Good catch, thank you! I guess you'd like to have a new tagged version, right? 😉 |
|
Yeah, if possible, thanks! The test failures are due to a new RecipesBase version that requires Julia 1.0 (which is why tests pass on 0.7 but not 1.0). |
|
An update: I'm willing to tag a new release as soon as possible, I'm just trying to understand what to do with RecipesBase: JuliaPlots/RecipesBase.jl#49 |
|
No worries, take your time. I'm not blocked by it. I'm using Measurements.jl in one of the examples for RigidBodySim.jl, but I've just disabled the test set that runs that example for now to get CI to pass. It's a very nice example for demos, but it's not the end of the world to tell people to check out Measurements master for now. |
|
v1. 0.1 released: JuliaLang/METADATA.jl#17841 |
Before this,
Measurement{Float64}(2//1)would result inon Julia 1.0.