-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significant digits REPL representation #30
Significant digits REPL representation #30
Conversation
shows only significant digits of `Measurement` objects in the REPL. Relates to JuliaPhysics#5 as a proof of concept.
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 97.27% 96.98% -0.29%
==========================================
Files 8 8
Lines 513 531 +18
==========================================
+ Hits 499 515 +16
- Misses 14 16 +2
Continue to review full report at Codecov.
|
@@ -101,6 +101,17 @@ measurement | |||
# Type representation | |||
Base.show(io::IO, measure::Measurement) = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove this method (or the method you defined can use the signature of this one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mine is already using this in the else
branch, since print
will call show
Thanks for addressing this, I was thinking about something like this. Please, add some tests to the "Test representation" |
still need to implement it for |
That should be all? |
Merged, thanks! |
shows only significant digits of
Measurement
objects in the REPL.Relates to #5 as a proof of concept.