Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating a useless tuple from an array in at-uncertain macro #32

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

giordano
Copy link
Member

Thanks @dpshelio for spotting this!

For example, on master:

julia> @benchmark @uncertain atan(1, 2)
BenchmarkTools.Trial: 
  memory estimate:  864 bytes
  allocs estimate:  26
  --------------
  minimum time:     933.957 ns (0.00% GC)
  median time:      960.522 ns (0.00% GC)
  mean time:        1.265 μs (19.62% GC)
  maximum time:     1.731 ms (99.90% GC)
  --------------
  samples:          10000
  evals/sample:     23

With this PR:

julia> @benchmark @uncertain atan(1, 2)
BenchmarkTools.Trial: 
  memory estimate:  768 bytes
  allocs estimate:  22
  --------------
  minimum time:     495.918 ns (0.00% GC)
  median time:      517.732 ns (0.00% GC)
  mean time:        594.881 ns (10.37% GC)
  maximum time:     211.667 μs (99.72% GC)
  --------------
  samples:          10000
  evals/sample:     194

@codecov-io
Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files           9        9           
  Lines         523      523           
=======================================
  Hits          509      509           
  Misses         14       14
Impacted Files Coverage Δ
src/math.jl 99.73% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf46595...b25faa4. Read the comment docs.

@giordano giordano merged commit da72bdb into master Mar 1, 2019
@giordano giordano deleted the no-tuple branch March 1, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants