Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing measurement with decimal uncertainty #45

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

giordano
Copy link
Member

@giordano giordano commented Jun 3, 2019

Fix #44. @alusiani Could you please check that I got it correctly? Thanks!

@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #45 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage    96.3%   96.31%   +<.01%     
==========================================
  Files          12       12              
  Lines         542      543       +1     
==========================================
+ Hits          522      523       +1     
  Misses         20       20
Impacted Files Coverage Δ
src/parsing.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8656a3b...7d88760. Read the comment docs.

@alusiani
Copy link

alusiani commented Jun 4, 2019

Fix #44. @alusiani Could you please check that I got it correctly? Thanks!
Thanks! The modification works fine! The branch Measurements#decimal-error now correctly parses results with decimal errors as I saw reported in Particle Physics paper.

@giordano
Copy link
Member Author

giordano commented Jun 4, 2019

Great, thanks for checking

@giordano giordano merged commit a82f66e into master Jun 4, 2019
@giordano giordano deleted the decimal-error branch June 4, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deal with floating point uncertainty in measurement("123.4(2.1)")
3 participants