Distance to Surface for Remaining Surface Primitives #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhagemann
reviewed
May 17, 2021
Comment on lines
239
to
241
| lMin::T, lMax::T = get_l_limits(r) | ||
| wMin::T, wMax::T = get_w_limits(r) | ||
| if l in lMin..lMax && w in wMin..wMax |
There was a problem hiding this comment.
Can we use existing internal functions (similar to _in_planar_u)?
If r.l and r.w are Intervals, we would determine the edges and create a "new" interval from them.
There was a problem hiding this comment.
3 options.
_in_planar_uwould work but then you have to create PlanarPoints- use multiple dispatch. This would be a lot of unnecessary code
- leave as is. Creates new intervals.
All have drawbacks.
Is this the same object? The cutout of the |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distance_to_surface()added to RegularPolygon, RegularPrismMantle, and RectangleAll are type stable, allocation free and have a worst case btime of ~50ns
rp = CSG.RegularPolygon(7,0.8,1.3,0)rpm = CSG.RegularPrismMantle(3,1.3,1)rec = CSG.RectangleX(0.5, 1, -1.2, 0.6, 0)rec = CSG.RectangleZ(0.5, 1, -1.2, 0.6, 0.5)