Update Documentation #165
Update Documentation #165
Conversation
|
If we want to drop support for Julia 1.0, we couĺd also incorporate lines 29-33 back: which will replace |
|
Also, is this PR mostly about the tutorial or also about docstrings? |
|
It is only about the tutorial in the documentation. But the plot recipes will need some further adjustments / improvements. |
|
Regarding the Julia 1.0 comment: |
| r = r[2], | ||
| φ = φ, | ||
| θ = θ | ||
| ) - Ellipsoid{T,ClosedPrimitive,T,typeof(φ),typeof(θ)}( |
There was a problem hiding this comment.
Shouldn't this be an OpenPrimitive? Or do we want the inner radius excluded?
Also, treating a Sphere with an inner radius r1 != 0 results in failing tests.
There was a problem hiding this comment.
Ah correct, that should be an OpenPrimitive.
Yes, the IO is not perfect yet. Also for other primitives.
That is something I want to talk about but not tackle in this PR.
| csguniontype --> :difference | ||
| csg.a | ||
| label --> "CSG" | ||
| linestyle := isClosedPrimitive(ps[1]) ? :solid : :dot |
There was a problem hiding this comment.
So this means, that OpenPrimitives are always the negative geometry of a CSGDifference?
There was a problem hiding this comment.
No. Differences of Differences switches Open an Closed and so on...
There is no ideal solution for plotting this. This is just a simple way to have a look at the CSG.
But for sure nothing for a publication.
No description provided.