-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up for v0.6.0 release #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midpoints is already defined in StatsBase.jl which is imported by SolidStateDetectors.jl
We might want to change this to |
I would leave this PR as is and suggest one final PR before the v0.6.0 release in which we take care of code style, e.g.:
|
Sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some cleanup for the v0.6.0 release.
Grid
get_world_limits_from_objects
(de97af5)endpoints
andwidth
replaced self-written ones ( c942aa8, 22ec004, 80ce13e)LengthQuantity
andAngleQuantity
were moved fromSolidStateDetectors
toConstructiveSolidGeometry
(e2fc079)to_internal_units
was changed (b24d6ed) to only expect one argument (and determine the internal unit from the argument)input_units
match what they are describing (984e8ad)