Fix constructor of BoggsChargeTrappingModel
#438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhagemann
changed the title
BoggsChargeTrappingModelBoggsChargeTrappingModel
|
With the last push, the constructor now performs as explained in the documentation: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the constructor of
BoggsChargeDriftModelwould just completely ignore the section with theparameters.Now, they are properly parsed.
The constructor can now take two sorts of dictionaries:
and just
The latter might be convenient when defining the
BoggsChargeDriftModelin code, e.g.BoggsChargeDriftModel{T}(Dict("nσe-1" => "1000cm"))and ensures that this PR is non-breaking (this is what the previous method did).