Performance fix + Extend tests (comparison to analytic solutions) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ighting potentials
in case one only wants to have the waveform for one channel.
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 45.93% 44.63% -1.31%
==========================================
Files 70 72 +2
Lines 5621 5673 +52
==========================================
- Hits 2582 2532 -50
- Misses 3039 3141 +102
Continue to review full report at Codecov.
|
It took too much time, since comparison to analytic solutions were added and also included some detector simulations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
getpropertyusage on a grid, e.g.grid.rbygrid.axes[1]to avoid performance issues.grid.rcan still be used to get the r-axis of the grid but should not be used inside the package or in time critical code for now.