Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added inner_taper_width #55

Merged
merged 2 commits into from
Oct 24, 2020
Merged

Added inner_taper_width #55

merged 2 commits into from
Oct 24, 2020

Conversation

ffischer42
Copy link
Contributor

The inner_taper_width is now calculated when a taper_angle is given.

The inner_taper_width is now calculated when a taper_angle is given.
@lmh91
Copy link
Collaborator

lmh91 commented Sep 18, 2020

Can you please use the Julia function deg2rad (or respectively rad2deg) instead of 2pi*x/360.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #55 into master will increase coverage by 1.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   44.10%   45.98%   +1.88%     
==========================================
  Files          72       72              
  Lines        5684     5882     +198     
==========================================
+ Hits         2507     2705     +198     
  Misses       3177     3177              
Impacted Files Coverage Δ
src/SolidStateDetector/SigGenInterface.jl 80.55% <100.00%> (+0.55%) ⬆️
src/ChargeDensityModels/ChargeDensityModels.jl 90.24% <0.00%> (-0.67%) ⬇️
src/SolidStateDetector/TransitionLayer.jl 0.00% <0.00%> (ø)
src/ChargeDriftModels/ChargeDriftModels.jl 100.00% <0.00%> (ø)
src/Geometries/SurfacePrimitives/Planes.jl 0.00% <0.00%> (ø)
...ionSetups/PotentialSimulationSetupRBCartesian3D.jl 99.56% <0.00%> (+<0.01%) ⬆️
...ionSetups/PotentialSimulationSetupRBCylindrical.jl 99.01% <0.00%> (+0.02%) ⬆️
...tialSimulation/SimulationAlgorithms/Cartesian3D.jl 79.67% <0.00%> (+0.16%) ⬆️
...tialSimulation/SimulationAlgorithms/Cylindrical.jl 82.43% <0.00%> (+0.36%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d38f7d...3829a94. Read the comment docs.

@lmh91 lmh91 merged commit 745bfd0 into JuliaPhysics:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants