Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hexagon plot recipe fix #82

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Hexagon plot recipe fix #82

merged 2 commits into from
Oct 29, 2020

Conversation

rjtayl
Copy link
Contributor

@rjtayl rjtayl commented Oct 28, 2020

Rotates the hexagon plot recipe by 30 degrees so that it agrees with the other functions in HexagonalPrism.jl

@oschulz oschulz requested a review from fhagemann October 28, 2020 18:22
fhagemann
fhagemann approved these changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@fhagemann fhagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.
I saw that the hexagons are only upright so far, but are there any plans on making these hexagonal primitives rotational? That might influence the plot recipes as well.

@lmh91
Copy link
Collaborator

lmh91 commented Oct 29, 2020

Well, first we need to add rotation of objects in general. For now this is totally fine.
Thanks for the fix!

@lmh91 lmh91 closed this Oct 29, 2020
@lmh91 lmh91 reopened this Oct 29, 2020
@lmh91 lmh91 merged commit 7b01c12 into JuliaPhysics:master Oct 29, 2020
@lmh91 lmh91 mentioned this pull request Oct 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhagemann fhagemann fhagemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjtayl @lmh91 @fhagemann