Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting the clims in plot recipes manually (Plots v1.7.4) #90

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

fhagemann
Copy link
Collaborator

This is a follow up to #80.

So far, clims of the ScalarPotential are set manually to prevent no plot showing up if all entries of the heatmap are identical.
This was fixed and is part of the master branch, but it is not released so far.

If Plots v1.7.4 is released, this pull request will remove the line that sets the clims manually.

@fhagemann fhagemann mentioned this pull request Nov 6, 2020
@lmh91
Copy link
Collaborator

lmh91 commented Nov 10, 2020

So, Plots v1.8.0 has been released: https://github.com/JuliaPlots/Plots.jl/releases/tag/v1.8.0.
I will restart the tests and merge if they run through.

@fhagemann
Copy link
Collaborator Author

fhagemann commented Nov 10, 2020

Well, I'm not sure whether this will affect anything in the tutorial.
The clims are only set manually if a heatmap consists only of one value (the charge density of the public_segBEGe for example).
I will test that locally.

@lmh91
Copy link
Collaborator

lmh91 commented Nov 10, 2020

I know, but you never know.
Please post your local test result.

@lmh91 lmh91 merged commit c721c90 into JuliaPhysics:master Nov 10, 2020
@fhagemann fhagemann deleted the Plots_v1.7.4 branch November 10, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants