Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates on the Geometry Primitives #97

Merged
merged 9 commits into from
Nov 13, 2020
Merged

Minor updates on the Geometry Primitives #97

merged 9 commits into from
Nov 13, 2020

Conversation

fhagemann
Copy link
Collaborator

@fhagemann fhagemann commented Nov 12, 2020 •
edited
Loading

  • added rotations around the z-axis to HexagonalPrism
    (right now with a scalar, should be replaced by a rotation matrix at some point)
  • added some consistency in the Tube and Cone code
  • minor fix in get_important_point in the Sphere primitive

lmh91
lmh91 approved these changes Nov 13, 2020
View reviewed changes
Copy link
Collaborator

@lmh91 lmh91 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't spend to much time on tuning the primitives.
Also don't add partial rotations in general.

We should talk at some point how to change the primitives in general to enable
fast rotation and translation. I have something in mind already.

@lmh91 lmh91 merged commit a07feda into JuliaPhysics:master Nov 13, 2020
@fhagemann fhagemann deleted the primitives branch November 13, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmh91 lmh91 lmh91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhagemann @lmh91