Skip to content

Commit

Permalink
revert later
Browse files Browse the repository at this point in the history
  • Loading branch information
isentropic committed Jan 16, 2024
1 parent 0a16cc5 commit be2087a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 12 deletions.
16 changes: 9 additions & 7 deletions ext/FileIOExt.jl
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ function _show_pdfbackends(io::IO, ::MIME"image/png", plt::Plot)
write(io, read(open(pngfn), String))
end

for be in (
Plots.PGFPlotsBackend, # NOTE: I guess this can be removed in [email protected]
)
showable(MIME"image/png"(), Plot{be}) && continue
@eval Plots._show(io::IO, mime::MIME"image/png", plt::Plot{$be}) =
_show_pdfbackends(io, mime, plt)
end
# Possibly need to create another extension that has both pgfplotsx and showio
# delete for now, as testing for pgfplotsx is hard; TODO restore later at @2.0
# for be in (
# Plots.PGFPlotsBackend, # NOTE: I guess this can be removed in [email protected]
# )
# showable(MIME"image/png"(), Plot{be}) && continue
# @eval Plots._show(io::IO, mime::MIME"image/png", plt::Plot{$be}) =
# _show_pdfbackends(io, mime, plt)
# end

end # module
10 changes: 5 additions & 5 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -49,21 +49,21 @@ for name in (
"misc",
"utils",
"args",
"defaults", # only legends failing
"defaults",
"dates",
"axes",
"layouts",
"contours",
"components",
"shorthands",
"recipes",
"unitful", # many fail
# "unitful", # many fail
# "hdf5plots",
# "pgfplotsx",
# "plotly",
"animations",
"output",
"preferences",
# "animations", # some failing
# "output", # some plotly failing
# "preferences", # no default backend
"backends",
)
@testset "$name" begin
Expand Down

0 comments on commit be2087a

Please sign in to comment.