Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace d by plotattributes #1107

Closed
8 of 14 tasks
jw3126 opened this issue Sep 23, 2017 · 2 comments
Closed
8 of 14 tasks

Replace d by plotattributes #1107

jw3126 opened this issue Sep 23, 2017 · 2 comments

Comments

@jw3126
Copy link
Contributor

jw3126 commented Sep 23, 2017

Replace d by plotattributes

The goal is to replace d by plotattributes inside @recipes. See here for the original issue. Of course that is a change that breaks a lot of packages, so there was a plan how to coordinate things. I started implementing it, but @mkborregaard wanted to wait until julia version requirement is bumped to 0.7. However I probably won't have time for this when we upgrade to 0.7. So I propose here a better plan, where almost all work can be done now, without breaking anything.

Step 1

  • Allow usage of both d and plotattributes inside @recipes. Without any deprecation warning.
  • Tag a new release for RecipesBase.

I searched all packages that depend on Plots or RecipesBase and none of them used the word plotattributes inside a recipe. So this is a safe step.

Step 2

  • Update d to plotattributes inside Plots.
  • Tag a new release for Plots.

Doing this after tagging Step 1 is important so all tests can pass.
After this step it is safe to use plotattributes instead of d in any other package.

Step 3

PRs to all packages that depend on Plots or Recipes to replace d by plotattributes.
While a lot of packages depend on these, only a few are using d:

  • DynamicMovementPrimitives
  • ImplicitEquations
  • LPVSpectral
  • PlotRecipes
  • StatPlots
  • SymPy
  • TimeSeries
  • ValueHistories

Step 4

  • When upgrading to julia 0.7 add depwarning for usage of d.

Step 5

  • When upgrading to 1.0 remove d altogether.

Do the maintainers of Plots agree with this?

@daschw
Copy link
Member

daschw commented Sep 25, 2017

To me this sounds like a great plan!

@mkborregaard
Copy link
Member

Yes, sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants