Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace d #12

Merged
merged 2 commits into from
Oct 3, 2017
Merged

Replace d #12

merged 2 commits into from
Oct 3, 2017

Conversation

jw3126
Copy link
Contributor

@jw3126 jw3126 commented Oct 3, 2017 •
edited
Loading

@Evizero Evizero self-assigned this Oct 3, 2017
@Evizero
Copy link
Member

Evizero commented Oct 3, 2017

nice! Thanks for doing this. Lets see what CI has to say.

@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 80.357% when pulling 255277d on jw3126:replaceD into ff93a1c on JuliaML:master.

@jw3126
Copy link
Contributor Author

jw3126 commented Oct 3, 2017

CI complains, but not about this PR I think.

@Evizero
Copy link
Member

Evizero commented Oct 3, 2017

I don't mind nightly failures at this point.

Thanks !

@Evizero Evizero merged commit 2201450 into JuliaML:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Evizero Evizero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jw3126 @Evizero @coveralls