Replace a few uses of 1:length idiom with eachindex

[brenhinkeller]

Not exhaustive, but I think this catches the only places this idiom was used together with @inbounds. Should be a simple swap out.

[isentropic]

Let's merge one the tests pass

[codecov]

Codecov Report

Merging #4210 (4f6cd0a) into master (de96717) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4210      +/-   ##
==========================================
+ Coverage   77.88%   77.91%   +0.03%     
==========================================
  Files          28       28              
  Lines        7081     7083       +2     
==========================================
+ Hits         5515     5519       +4     
+ Misses       1566     1564       -2     

Impacted Files	Coverage Δ
src/utils.jl	62.22% <0.00%> (ø)
src/recipes.jl	64.57% <0.00%> (+0.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de96717...4f6cd0a. Read the comment docs.

[mkborregaard]

Weird - these must have been added after #2304 ? Implementing the general array interface back then was a lot of effort

[brenhinkeller]

Huh. Oh I'll bet.. There were a few others that popped up as well when searching https://pkg.juliahub.com/ui/Search?type=code&q=1%3Alength&r=true&p=Plots%3A91a5bcdd-55d7-5caf-9e0b-520d859cae80
but not with @inbounds and many not in for loops so I was less sure what the best replacement would be; some of those may actually be OK.

[isentropic]

Perhaps you could also capture the rest and we merge it in altogether?

[brenhinkeller]

Sure!

[brenhinkeller]

Hmm, it didn't like that at all... Switching back to just the two easy ones for now

[isentropic]

That's a little strange, not sure why such things could happen

[brenhinkeller]

Yeah, not sure.. they seemed innocuous enough but I guess it's the first time I've spent any time with this codebase. Looks better now I guess though!

[BeastyBlacksmith]

Thanks for diggin in and since this is your first contribution, you might want to take a look at #3503 .

[brenhinkeller]

Oh cool! Thanks!