Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of run_directory when static_export option is given #28

Closed
wants to merge 1 commit into from
Closed

Fix behavior of run_directory when static_export option is given #28

wants to merge 1 commit into from

Conversation

hasundue
Copy link

When static_export option is given, other settings are overwritten with default values.
You know this is not the best way to fix that, so you do not necessarily have to merge this, obviously.

@fonsp
Copy link
Member

fonsp commented Nov 23, 2021

Thanks! I moved this logic in #31 to

slider_server_url_js = if slider_server_running_somewhere
abs_path = joinpath(start_dir, path)
url_of_root = relpath(start_dir, dirname(abs_path)) # e.g. "." or "../../.."
repr(something(
settings.Export.slider_server_url,
url_of_root
))
else
"undefined"
end
. This solves your issue, since the setting settings.Export.slider_server_url takes precedence.

@fonsp fonsp closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants