Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
jw3126 committed Oct 28, 2018
1 parent bb9799d commit 5f28c96
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/pyiterator.jl
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ else
# avoid the constructor that calls length
# since that might be an expensive operation
# even if length is cheap, this adds 10% performance
piter = PyIterator{PyAny, Base.IteratorSize}(po)

DummyNeverUsed = Base.SizeUnknown
piter = PyIterator{PyAny, DummyNeverUsed}(po)

This comment has been minimized.

Copy link
@stevengj

stevengj Nov 3, 2018

Member

This seems like an odd way to write the code. Why not just use a comment if you want to remark that the second parameter is currently unused?

iterate(piter, s)
end
end
Expand Down

0 comments on commit 5f28c96

Please sign in to comment.