Test find_libpython #595
Merged
Test find_libpython #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
added a commit
to tkf/PyCall.jl
that referenced
this pull request
Oct 17, 2018
The previous code accidentally worked presumably because $PWD was set do deps when running deps/build.jl. Cherry-picked from JuliaPy#595.
This was referenced Oct 17, 2018
Merged
tkf
force-pushed
the
fix-find_libpython
branch
from
fa635ab to
325f16b
Compare
stevengj
reviewed
Oct 17, 2018
deps/buildutils.jl
Outdated
| env = copy(ENV) | ||
| if dirname(cmd.exec[1]) == abspath(Conda.PYTHONDIR) | ||
| pythonvars = String[] | ||
| for var in keys(env) |
There was a problem hiding this comment.
shouldn't we just call Conda._set_conda_env?
There was a problem hiding this comment.
Yeah, this may be required for Conda with Python >= 3.7. JuliaPy/Conda.jl#125 (comment)
It's probably better to define Conda.run which is like Base.run but with appropriate environment variables. I think you'll need it in IJulia as well to let Python running Jupyter server to load appropriate DLL in Windows. Using "private" function starting with underscore is a bit awkward.
stevengj
pushed a commit
that referenced
this pull request
Oct 17, 2018
* Fix show_dlopen_error See the first version of the comment #592 (comment) * Fix a possible bug in exec_find_libpython The previous code accidentally worked presumably because $PWD was set do deps when running deps/build.jl. Cherry-picked from #595.
tkf
force-pushed
the
fix-find_libpython
branch
2 times, most recently
from
bdb3b91 to
eb797f7
Compare
tkf
force-pushed
the
fix-find_libpython
branch
from
eb797f7 to
7df92b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
I think
deps/build.jlis complex enough to require some tests. I should have added some tests in #556.This PR fixes a yet another bug introduced in #556. From the first version of the comment #592 (comment):
The error was produced here:
PyCall.jl/deps/build.jl
Lines 61 to 63 in ae9bbba
closes #596
I opened an alternative fix-only version here: #596