Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building of documentation #190

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Fix building of documentation #190

merged 2 commits into from
Oct 10, 2021

Conversation

schillic
Copy link
Member

Closes #188.

This has also two code changes where the result is wrapped in an IntervalMatrix.

@schillic schillic merged commit 88cdd49 into master Oct 10, 2021
@schillic schillic deleted the schillic/188 branch October 10, 2021 18:22
@schillic schillic removed the request for review from mforets October 10, 2021 18:23
[1, 4.5] [-3, 2]
[-4, 2.5] [-1, 9]
[0.5, 4.5] [-3.25, 2.5]
[-4.25, 3] [-2.25, 9]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change due to the new multiplication settings default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so.

@@ -89,12 +89,12 @@ julia> (-1.0..1.0) * A

Or compute the square of $A$,
```jldoctest quickstart
julia> A*A
julia> square(A)
Copy link
Member

@mforets mforets Oct 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the intent of this paragraph was to show operations that "just work" with interval matrices, hence the A * A, and to introduce specialized methods in the next paragraph. i can send a small change in a new PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it because A*A now gives much wider intervals.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i think that's ok for motivation of this package, but we have to add the result using square.

we can also show the result upon changing the multiplication mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doctests failing on julia v1.6.3
3 participants