check convexity in line segment #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
approved these changes
Jul 15, 2022
lucaferranti
approved these changes
Jul 15, 2022
schillic
reviewed
Jul 15, 2022
|
@schillic (continuing from the previous comment) what is the ambiguity? |
|
You can open the log in the build. |
julia> Aqua.test_ambiguities(LazySets)
Skipping LazySets.Assertions.are_assertions_enabled
4 ambiguities found
Ambiguity #1
issubset(X::LazySets.ConvexSet, P::LazySets.ConvexSet, witness::Bool) in LazySets at /home/lferrant/.julia/dev/LazySets/src/ConcreteOperations/issubset.jl:71
issubset(L::LazySets.LineSegment{N, VN} where VN<:AbstractVector{N}, S::ST, witness::Bool) where {N, ST<:LazySets.LazySet{N}} in LazySets at /home/lferrant/.julia/dev/LazySets/src/ConcreteOperations/issubset.jl:492
Possible fix, define
issubset(::LazySets.LineSegment{N, VN} where VN<:AbstractVector{N}, ::ST, ::Bool) where {N, ST<:LazySets.ConvexSet{N}}
Ambiguity #2
issubset(P::LazySets.AbstractPolytope, S::LazySets.ConvexSet) in LazySets at /home/lferrant/.julia/dev/LazySets/src/ConcreteOperations/issubset.jl:213
issubset(L::LazySets.LineSegment{N, VN} where VN<:AbstractVector{N}, S::ST) where {N, ST<:LazySets.LazySet{N}} in LazySets at /home/lferrant/.julia/dev/LazySets/src/ConcreteOperations/issubset.jl:492
Possible fix, define
issubset(::LazySets.LineSegment{N, VN} where VN<:AbstractVector{N}, ::ST) where {N, ST<:LazySets.ConvexSet{N}}
Ambiguity #3
issubset(P::LazySets.AbstractPolytope, S::LazySets.ConvexSet, witness::Bool; algorithm) in LazySets at /home/lferrant/.julia/dev/LazySets/src/ConcreteOperations/issubset.jl:213
issubset(L::LazySets.LineSegment{N, VN} where VN<:AbstractVector{N}, S::ST, witness::Bool) where {N, ST<:LazySets.LazySet{N}} in LazySets at /home/lferrant/.julia/dev/LazySets/src/ConcreteOperations/issubset.jl:492
Possible fix, define
issubset(::LazySets.LineSegment{N, VN} where VN<:AbstractVector{N}, ::ST, ::Bool) where {N, ST<:LazySets.ConvexSet{N}}
Ambiguity #4
issubset(X::LazySets.ConvexSet, P::LazySets.ConvexSet) in LazySets at /home/lferrant/.julia/dev/LazySets/src/ConcreteOperations/issubset.jl:71
issubset(L::LazySets.LineSegment{N, VN} where VN<:AbstractVector{N}, S::ST) where {N, ST<:LazySets.LazySet{N}} in LazySets at /home/lferrant/.julia/dev/LazySets/src/ConcreteOperations/issubset.jl:492
Possible fix, define
issubset(::LazySets.LineSegment{N, VN} where VN<:AbstractVector{N}, ::ST) where {N, ST<:LazySets.ConvexSet{N}}
Test Failed at /home/lferrant/.julia/packages/Aqua/HWLbM/src/ambiguities.jl:117
Expression: success(pipeline(cmd; stdout = stdout, stderr = stderr))
ERROR: There was an error during testing |
|
a |
schillic
reviewed
Jul 15, 2022
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Luca Ferranti <[email protected]>
lucaferranti
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
(not sure if my review counts anymore given I also committed, but...) LGTM, a couple of things that could be added
- A
test_throwfor the fallback case (arguably quite pedantic) - A test for the case
witness=true(falls out of the original scope of the PR, but since the change was incorporated)
i opened #3008 |
schillic
added a commit
that referenced
this pull request
Aug 3, 2022
* check convexity in line segment * Update docs/src/lib/binary_functions.md * fix ambiguity * Update src/ConcreteOperations/issubset.jl Co-authored-by: Christian Schilling <[email protected]> * Update src/ConcreteOperations/issubset.jl Co-authored-by: Luca Ferranti <[email protected]> Co-authored-by: Christian Schilling <[email protected]> Co-authored-by: Luca Ferranti <[email protected]>
schillic
added a commit
that referenced
this pull request
Aug 3, 2022
* change LazySet to ConvexSet * rename file LazySet.jl -> ConvexSet.jl * rename another LazySet.jl to ConvexSet.jl * add abstract LazySet type * update docs * update docstring * check convexity in line segment (#3007) * check convexity in line segment * Update docs/src/lib/binary_functions.md * fix ambiguity * Update src/ConcreteOperations/issubset.jl Co-authored-by: Christian Schilling <[email protected]> * Update src/ConcreteOperations/issubset.jl Co-authored-by: Luca Ferranti <[email protected]> Co-authored-by: Christian Schilling <[email protected]> Co-authored-by: Luca Ferranti <[email protected]> Co-authored-by: Marcelo Forets <[email protected]> Co-authored-by: Christian Schilling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.