Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: SAMtools v0.0.1 #16341

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Jun 14, 2020

JuliaRegistrator referenced this pull request in aramirezreyes/AvailablePotentialEnergyFramework.jl Jun 14, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2020

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JuliaRegistrator JuliaRegistrator force-pushed the registrator/samtools/ce1b76f3/v0.0.1 branch from a06d2a8 to 92a223e Compare June 14, 2020 02:37
JuliaRegistrator referenced this pull request in aramirezreyes/AvailablePotentialEnergyFramework.jl Jun 14, 2020
UUID: ce1b76f3-601c-5192-adf8-a07e935792b9
Repo: https://github.com/aramirezreyes/SAMtools.jl.git
Tree: d93699a0e0152f698c8d98267027f9fbbab6b47c

Registrator tree SHA: 58e84c9733c0606ca53349dbce519209d8a8402b
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/samtools/ce1b76f3/v0.0.1 branch from 92a223e to 8bbb80c Compare June 14, 2020 03:45
JuliaRegistrator referenced this pull request in aramirezreyes/AvailablePotentialEnergyFramework.jl Jun 14, 2020
@github-actions github-actions bot merged commit 1f7ade1 into master Jun 17, 2020
@github-actions github-actions bot deleted the registrator/samtools/ce1b76f3/v0.0.1 branch June 17, 2020 02:13
@fredrikekre
Copy link
Member

Why did you rename this? I will revert this merge because we can't have two folders called SAMTools and SAMtools.

fredrikekre added a commit that referenced this pull request Jun 17, 2020
fredrikekre added a commit that referenced this pull request Jun 17, 2020
@fredrikekre
Copy link
Member

This should probably also have failed CI IMO? cc @DilumAluthge

We don't really have any written out guidelines about multiple packages with the same name, or packages with cases shifted like this. Would be good to spell out that.

@ValentinKaisermayer
Copy link

Why did you rename this? I will revert this merge because we can't have two folders called SAMTools and SAMtools.

There are really two packages I think:
https://github.com/natgeo-wong/SAMTools.jl This was and is now again in registry
https://github.com/aramirezreyes/SAMtools.jl

@fredrikekre
Copy link
Member

Ah, thought it was by the same author.

@ValentinKaisermayer
Copy link

Isn't that even worse? It is not a rename but a package got overwritten. Checking the uuid would have shown that.

@fredrikekre
Copy link
Member

It didn't get overwritten, it was fully functional on file systems that can differentiate by letter cases.

@aramirezreyes
Copy link

aramirezreyes commented Jun 17, 2020 via email

@fredrikekre
Copy link
Member

Yea it's not your fault. Hopefully the packages do similar things so maybe it makes sense to join efforts.

@aramirezreyes
Copy link

I renamed my package, should I create a new UUID before trying to register with the new name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants